Repository navigation
Changes needed for ufo pr 4112 - #283
Merged
Merged
Conversation
Michael Cooke (mikecooke77)
had a problem deploying
to
CI
April 24, 2026 05:56 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Michael Cooke (mikecooke77)
temporarily deployed
to
CI
April 24, 2026 06:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Chris Thomas (ctgh)
approved these changes
Apr 24, 2026
Chris Thomas (ctgh)
left a comment
Chris Thomas (ctgh)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks!
Adam Maycock (adammaycock)
approved these changes
Apr 24, 2026
Adam Maycock (adammaycock)
added
the
coordinate merge
David Davies (DJDavies2)
approved these changes
Apr 25, 2026
|
The upstream oops/ufo PRs were merged: you can now merge this. |
Collaborator
|
Francois Hebert (@fmahebert) Thanks! |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is needed because of changes to pass the qc flags and errors as references rather than shared pointers in ufo, https://github.com/JCSDA-internal/ufo/pull/4112.
I have also added the explicit declaration of extradiagvars_ in the constructors as I think this is good practice.
This is a coordinated merge with the following prs:
build-group=https://github.com/JCSDA-internal/oops/pull/3267
build-group=https://github.com/JCSDA-internal/pyiri-jedi/pull/174
build-group=MetOffice/nemo-feedback#82
build-group=https://github.com/JCSDA-internal/ufo/pull/4112
The full mobundle testing has been run and output can be found here:
https://cylchub/services/cylc-review/cycles/michael.c.cooke/?suite=mobundle-ufo4112
The failure in ufo for the mo-bundle testing is a known problem with a ufo ctest and unrelated to this change:
https://cylchub/services/cylc-review/view/michael.c.cooke?&suite=mobundle-ufo4112&no_fuzzy_time=0&path=log/job/1/ctest_all_ufo__spice_gnu_debug/01/job.out#2106
Testing has been conducted with one of the sith kgo runs to show the change does not affect results:
https://cylchub/services/cylc-review/taskjobs/michael.c.cooke?&suite=sith_ufo4112%2Fkgo_glu&cycles=20210701T1200Z