[HEBaron]

PR Summary

Sci/Tech Reviewer: iboutle
Code Reviewer: Cameron Bateman (@cameronbateman-mo)

Updating arguments in jule_extra_kernel to maintain consistency with recent developments in JULES.

Closes issue #863
Linked PRs
https://github.com/MetOffice/um/pull/148, MetOffice/jules#149

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the HPC Optimisation Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[iboutle]

Just one comment

[iboutle]

I would suggest making these parameters rather than runtime variables

[Cameron Bateman (cameronbateman-mo)]

Looks good, approved.

[iboutle]

I'm puzzled what's going on here - Doug appears to have changed his PR to include my suggestion, but this one is unchanged - can we ensure they are consistent please.

[Cameron Bateman (cameronbateman-mo)]

Yeah sorry I approved this to soon. It needs iboutle comment answered/implemented. You also need to verify your previous commits there is some information here that should help https://metoffice.github.io/simulation-systems/WorkingPractices/gh_authorisation.html#verified-commits