Repository navigation
Add CLA check workflow, CLA.md and CONTRIBUTORS.md - #109
Open
isabellaascione wants to merge 1 commit into
Open
isabellaascione wants to merge 1 commit into
isabellaascione wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #108
related to #65
This PR adds a Contributor Licence Agreement (CLA) process to ProFSea-tool, replicating the setup already in place in the growss repo, by reusing its shared workflow rather than duplicating the check logic.
Files added (no existing files modified):
.github/workflows/cla-check.yaml — thin workflow triggered on pull_request_target that calls the reusable MetOffice/growss/.github/workflows/cla-check.yaml@main workflow, passing cla-url pointing to this repo's CLA.md.
CLA.md — the CLA terms for ProFSea-tool.
CONTRIBUTORS.md — the signature record. Contributors sign by adding a row (GitHub username, name, affiliation, date) in their PR; the workflow checks this file for the PR author's username.
How it works: on each PR, the workflow checks whether the author's GitHub username is already present in CONTRIBUTORS.md on the base branch; if not, it checks the PR branch itself (so new contributors can sign as part of their first PR).
The CLA text (converted from a supplied Word document) contains a couple of sentences that appear to reference a different tool, CLA Assistant (a bot-based signing system with a "Sign in with GitHub to agree" button), rather than the CONTRIBUTORS.md-based process actually implemented here:
"Please confirm acceptance of this CLA by clicking the 'Sign in with GitHub to agree' button below."
"To end this Agreement please follow the instructions on the CLA Assistant dashboard."
Since this setup does not use CLA Assistant, these lines don't match the actual workflow and likely need to be removed or reworded. I've raised this separately for confirmation before finalising the wording in CLA.md.