Fill approved Link cards in hosted payment frames - #159
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenInstinct stopped before Link approval when checkout used processor-hosted card fields.
fill_from_linknow accepts an exact checkout URL and explicit field bindings, resolves unique visible inputs across supported payment frames, and fills the approved one-time card inside application code. This retains the official Eve Link extension's wallet and purchase-approval flow.The executor discovers out-of-process descendants through CDP parent relationships, pins page and frame URLs including fragments, handles formatted inputs and padded/unpadded expiration-month selects, checks ancestor-frame visibility before discovery and each write, and masks filled controls. Existing same-origin vault protection and legacy native card autofill remain in place. Unknown frame origins, duplicate or ambiguous targets, and uncertain writes stop execution; filling does not submit checkout.
Related to #157.
Validation:
pnpm check: all six tasks passed; 803 tests across 90 files.pnpm buildandpnpm exec eve build: passed.Browser fixtures use controlled HTML served at the listed origins. Actual processor sandbox checkouts and live purchases have not been tested.
Independent review identified month-option encoding and ancestor-frame visibility gaps. Both were corrected and verified with focused regressions and real-browser fixtures. The final visibility repair has not had another independent review.