Fix Link callback ownership for Eve inbox tokens - #155
Merged
Merged
Conversation
This was referenced Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link consent saved the wallet successfully, but its return callback failed with
forbidden: Session not found. The ownership parser recognized older hook tokens and rejected Eve 0.66.3'seve:inbox:v1:wrapper before checking session ownership.Unwrap the recognized v1 inbox prefix before resolving the session ID. Keep workspace ownership checks, supported legacy tokens, and rejection of unknown token versions and kinds. Regression coverage includes the encoded Link callback path and an owned callback reaching Eve's actual callback handler.
Validation:
pnpm check(779 tests, all six tasks),pnpm build, andpnpm exec eve buildpassed. Focused callback and OAuth suites passed 11 tests; the original code failed the new regressions. Independent read-only review found no issues.