Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions agent/channels/linq.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,20 +97,27 @@ export default linqChannel({
.join("\n\n"),
},
];
if (event.authorization?.url)
parts.push({ type: "link", value: event.authorization.url });
const apiKey = await credentials.apiKey();
const client = new LinqAPIV3({ apiKey });
const idempotencyKey = `authorization:${session.session.id}:${event.attemptId ?? `${event.turnId}:${event.name}`}`;
const result = await client.chats.messages.send(chatId, {
message: {
parts,
idempotency_key: `authorization:${session.session.id}:${event.attemptId ?? `${event.turnId}:${event.name}`}`,
idempotency_key: `${idempotencyKey}:prompt`,
},
});
context.state.pendingAuthMessageIds = {
...context.state.pendingAuthMessageIds,
[event.name]: result.message.id,
};
// Linq requires a native link to be the message's only part.
if (event.authorization?.url)
await client.chats.messages.send(chatId, {
message: {
parts: [{ type: "link", value: event.authorization.url }],
idempotency_key: `${idempotencyKey}:link`,
},
});
},
async "action.result"(event, context, session) {
const reaction = reactToMessageToolResultSchema.safeParse(event.result);
Expand Down
77 changes: 54 additions & 23 deletions tests/agent/channels/linq-message-delivery.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,21 @@ interface LinqTestMessage {
describe("Linq message delivery", () => {
beforeEach(() => {
vi.clearAllMocks();
linqChannelCapture.sendNativeMessage
.mockReset()
.mockImplementation(async (_chatId, body) => {
const parts = body.message.parts ?? [];
if (parts.some((part) => part.type === "link") && parts.length !== 1)
throw new Error("400 link part must be the only part in the message");
return {
message: {
id:
parts[0]?.type === "link"
? "native-link-message"
: "native-text-message",
},
};
});
scheduleDeliveryCapture.finalize.mockResolvedValue(true);
scheduleDeliveryCapture.release.mockResolvedValue(true);
});
Expand Down Expand Up @@ -205,32 +220,46 @@ describe("Linq message delivery", () => {
expect(post).toHaveBeenCalledExactlyOnceWith({ raw: message });
});

it("delivers authorization as native text and a connection link without Markdown conversion", async () => {
it("delivers authorization text and its native link as separate messages accepted by Linq", async () => {
const { context, post } = handlerContext();
const event = authorizationEvent();
await handleAuthorizationRequired(event, context, sessionContext());

expect(
linqChannelCapture.sendNativeMessage
).toHaveBeenCalledExactlyOnceWith("chat-1", {
message: {
idempotency_key: "authorization:session-1:auth-attempt",
parts: [
{
type: "text",
value:
"Connect your Link wallet to continue.\n\nPurchases require separate approval.",
},
{
type: "link",
value:
"https://example.com/api/link?attempt=00000000-0000-4000-8000-000000000001",
},
],
},
});
expect(linqChannelCapture.sendNativeMessage).toHaveBeenCalledTimes(2);
expect(linqChannelCapture.sendNativeMessage).toHaveBeenNthCalledWith(
1,
"chat-1",
{
message: {
idempotency_key: "authorization:session-1:auth-attempt:prompt",
parts: [
{
type: "text",
value:
"Connect your Link wallet to continue.\n\nPurchases require separate approval.",
},
],
},
}
);
expect(linqChannelCapture.sendNativeMessage).toHaveBeenNthCalledWith(
2,
"chat-1",
{
message: {
idempotency_key: "authorization:session-1:auth-attempt:link",
parts: [
{
type: "link",
value:
"https://example.com/api/link?attempt=00000000-0000-4000-8000-000000000001",
},
],
},
}
);
expect(context.state.pendingAuthMessageIds).toEqual({
link: "native-message-1",
link: "native-text-message",
});
expect(post).not.toHaveBeenCalled();
});
Expand All @@ -245,8 +274,10 @@ describe("Linq message delivery", () => {
([, body]) => body.message.idempotency_key
)
).toEqual([
"authorization:session-1:auth-attempt",
"authorization:session-1:auth-attempt",
"authorization:session-1:auth-attempt:prompt",
"authorization:session-1:auth-attempt:link",
"authorization:session-1:auth-attempt:prompt",
"authorization:session-1:auth-attempt:link",
]);
});

Expand Down
Loading