Skip to content

Fix origin rejection when connecting Link #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmhall merged 1 commit into from
Oct 2, 2026
Merged

Fix origin rejection when connecting Link #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/(authenticated)/link/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import { applicationOrigin } from "@shared/environment/origin";

export const metadata = {
title: "Link wallet",
referrer: "no-referrer" as const,
// Native form POSTs need their Origin header for the route's CSRF check.
// Cross-origin navigations still receive no referrer.
referrer: "same-origin" as const,
};

export default async function Page({ searchParams }: PageProps<"/link">) {
Expand Down
7 changes: 7 additions & 0 deletions tests/integration/link.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,16 @@ describe("Link wallet integration", () => {
const denied = request();
denied.headers.set("origin", "https://attacker.example");
expect((await POST(denied)).status).toBe(403);
const opaqueOrigin = request();
opaqueOrigin.headers.set("origin", "null");
expect((await POST(opaqueOrigin)).status).toBe(403);
const missingOrigin = request();
missingOrigin.headers.delete("origin");
expect((await POST(missingOrigin)).status).toBe(403);

const started = await POST(request());
expect(started.status).toBe(303);
expect(started.headers.get("referrer-policy")).toBe("no-referrer");
const destination = new URL(started.headers.get("location") ?? "");
expect(destination.origin).toBe("https://login.link.com");
expect(destination.searchParams.get("redirect_uri")).toBe(
Expand Down
Loading