test: delete three tests a sibling already covers - #1876
Merged
Conversation
An audit of every test suite for tautological tests (MRGFY-10043) found three tests here that cannot catch a defect the rest of the suite misses: - recover_pending_rejects_plain_reason never reaches recover_pending's own logic, since plain text is rejected by parse() first. parse_plain_reason_returns_none covers that, and recover_pending_rejects_mismatched_last_entry covers the filter. - detect_local_timezone_returns_a_value exercises iana-time-zone and the host environment through a one-line wrapper. It fails only if the wrapper always errors. - skill_content_is_readable is strictly subsumed by skill_has_valid_frontmatter, which reads the same file and also needs its frontmatter. Delete them. Related to MRGFY-10043 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Change-Id: Ie703b6e2f3da9b26092e71fca350d031f5331fd9
Contributor
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. Show 6 satisfied protections🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The timezone test has no sibling coverage and its removal leaves the default-timezone path untested.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Removes three tests identified as redundant or low-value.
Changes:
- Removes redundant revision-note and skill readability tests.
- Removes the only test covering local timezone detection.
| File | Description |
|---|---|
crates/mergify-stack/src/revision_note.rs |
Removes a parse-path duplicate test. |
crates/mergify-freeze/src/common.rs |
Removes timezone detection coverage. |
crates/mergify-cli/tests/skill_references.rs |
Removes a test subsumed by frontmatter validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kozlek
approved these changes
Oct 5, 2026
sileht
approved these changes
Oct 5, 2026
Contributor
Merge Queue Status
This pull request spent 6 minutes 24 seconds in the queue, including 6 minutes 3 seconds running CI. Required conditions to merge
|
34 of 40 tasks
mergify
Bot
deleted the
devs/jd/jd/mrgfy-10043-delete-tautological-tests/delete-three-tests-sibling-already-covers--e703b6e2
branch
October 5, 2026 12:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An audit of every test suite for tautological tests (MRGFY-10043) found
three tests here that cannot catch a defect the rest of the suite
misses:
own logic, since plain text is rejected by parse() first.
parse_plain_reason_returns_none covers that, and
recover_pending_rejects_mismatched_last_entry covers the filter.
host environment through a one-line wrapper. It fails only if the
wrapper always errors.
skill_has_valid_frontmatter, which reads the same file and also needs
its frontmatter.
Delete them.
Related to MRGFY-10043
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com