feat(ci): Fetch quarantines from the list endpoint in junit-process - #1871
Merged
Conversation
Contributor
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. Show 6 satisfied protections🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generalized ignored-status handling can bypass mandatory retries and conceal server or rate-limit failures.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates JUnit quarantine evaluation to use the paginated quarantine list endpoint and handle unavailable-plan responses gracefully.
Changes:
- Adds paginated GET support with configurable ignored status.
- Fetches all branch quarantines and treats HTTP 402 as an empty quarantine.
- Updates categorization, command behavior, and tests for the new response model.
| File | Description |
|---|---|
crates/mergify-core/src/http.rs |
Adds optional-status paginated requests. |
crates/mergify-ci/src/tests_quarantine.rs |
Shares the quarantine response envelope. |
crates/mergify-ci/src/junit_process/quarantine.rs |
Implements paginated quarantine fetching and categorization. |
crates/mergify-ci/src/junit_process/mod.rs |
Removes the obsolete public type export. |
crates/mergify-ci/src/junit_process/command.rs |
Adapts verdict logic and mocks to the list endpoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
`POST /quarantines/check` is superseded by the paginated `GET /quarantines?branch=…` list endpoint, which the mergify-ci-integrations clients already use. Align `ci junit-process` with them: page through the branch's quarantines, and treat a 402 (quarantine not in the plan) as nothing quarantined instead of reporting an error and blocking every failure. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Change-Id: I7a67e0c92132ccfede7d1b78b249a68129ae6fd0
remyduthu
force-pushed
the
devs/remyduthu/fix/quarantine-list-endpoint/fetch-quarantines-list-endpoint-junit-process--7a67e0c9
branch
from
October 1, 2026 17:22
0c70c26 to
82def28
Compare
Contributor
Author
Revision history
|
jd
approved these changes
Oct 1, 2026
sileht
approved these changes
Oct 1, 2026
Contributor
Merge Queue Status
This pull request spent 14 seconds in the queue, including 1 second running CI. Required conditions to merge
|
mergify
Bot
deleted the
devs/remyduthu/fix/quarantine-list-endpoint/fetch-quarantines-list-endpoint-junit-process--7a67e0c9
branch
October 1, 2026 22:03
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

POST /quarantines/checkis superseded by the paginatedGET /quarantines?branch=…list endpoint, which themergify-ci-integrations clients already use. Align
ci junit-processwith them: page through the branch's quarantines, and treat a 402
(quarantine not in the plan) as nothing quarantined instead of
reporting an error and blocking every failure.
Co-Authored-By: Claude Opus 5.5 (1M context) noreply@anthropic.com