Adjust the FA futility bound with same value as the efficacy bound for asymmetric beta-spending non-binding/binding designs - #656
Open
LittleBeannie wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The observed gsDesign practice is:
gsprob(), as shown at line 1612. The probability-complement logic in gsDesign2 achieves the same final partition, but it is not a line-for-line copy of gsDesign’s probability implementation.Both asymmetric binding and non-binding sample-size paths call
gsI1():gsDType3ss()gsDType4ss()The exact final-bound assignment is in
gsI1():Here,
bis the efficacy boundary. Because the futility boundary passed togsprob()is-x$b, assigningproduces
at the final analysis.
In this PR, my changes below are the gsDesign2 probability-complement implementation, not a call equivalent to
gsprob():It sets the final incremental futility probability so that
$$\sum_{i=1}^{K} P(\text{upper at } i)+\sum_{i=1}^{K} P(\text{lower at } i)= 1,$$ $P(\text{upper at }i)$ is the unconditional stagewise probability of first crossing the efficacy boundary at analysis $i$ , under the value of theta used for the power calculation; and $P(\text{lower at } i)$ is the unconditional probability that the trial first crosses the lower (futility) boundary at analysis $i$ .
where
Therefore, they do not recompute both crossing probabilities. They retain the already calculated upper and interim lower probabilities, then calculate the final lower probability as the remaining probability mass.