Skip to content

stop loading a lot of scripts when module is disabled.#12

Open
MrZhongzq wants to merge 1 commit intoMeowDump:mainfrom
MrZhongzq:main
Open

stop loading a lot of scripts when module is disabled.#12
MrZhongzq wants to merge 1 commit intoMeowDump:mainfrom
MrZhongzq:main

Conversation

@MrZhongzq
Copy link
Copy Markdown

When the module's disable file exists, all external side effects are now stopped:

  • post-fs-data.sh: removes all service.d scripts (prop.sh, hash.sh, lineage.sh, shamiko.sh, package.sh, .box_cleanup.sh) and system.prop, then exits immediately
  • service.sh: exits immediately before any resetprop calls or daemon loop
  • All service.d script templates (prop.sh, hash.sh, shamiko.sh, package.sh): check for disable file before executing
  • .box_cleanup.sh: also cleans up service.d scripts when module is disabled (previously only on uninstall)

Previously, disabling the module in Magisk had no effect because:

  1. service.d scripts persisted and ran every boot regardless
  2. service.sh applied resetprop calls without checking disable state
  3. post-fs-data.sh recreated service.d scripts every boot This caused system properties (security_patch, verifiedbootstate, etc.) to remain spoofed, which broke OTA updates (update_engine error 51).

…disabled

When the module's disable file exists, all external side effects are now
stopped:

- post-fs-data.sh: removes all service.d scripts (prop.sh, hash.sh,
  lineage.sh, shamiko.sh, package.sh, .box_cleanup.sh) and system.prop,
  then exits immediately
- service.sh: exits immediately before any resetprop calls or daemon loop
- All service.d script templates (prop.sh, hash.sh, shamiko.sh,
  package.sh): check for disable file before executing
- .box_cleanup.sh: also cleans up service.d scripts when module is
  disabled (previously only on uninstall)

Previously, disabling the module in Magisk had no effect because:
1. service.d scripts persisted and ran every boot regardless
2. service.sh applied resetprop calls without checking disable state
3. post-fs-data.sh recreated service.d scripts every boot
This caused system properties (security_patch, verifiedbootstate, etc.)
to remain spoofed, which broke OTA updates (update_engine error 51).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@MeowDump
Copy link
Copy Markdown
Owner

MeowDump commented Apr 4, 2026

you only need to exit the service.d scripts, thats it

  • service.sh & post-fs-data.sh doesn't run when the module is disabled
  • cleanup script runs once only when integrity box is not installed

@MeowDump
Copy link
Copy Markdown
Owner

MeowDump commented Apr 4, 2026

broke OTA updates (update_engine error 51).

v34.1-Integrity-Box-04-04-2026.zip

Please try this updated version. Sorry for the inconvenience, and thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants