Repository navigation
fix(memory): send Qwen thinking controls through SGLang and vLLM chat templates - #348
LeslieWylie wants to merge 4 commits into
Conversation
Route Qwen enable_thinking through chat_template_kwargs only for explicit sglang and vllm providers. Keep the generic OpenAI-compatible request body unchanged so cloud-provider calls retain their existing contract.
Signed-off-by: LeslieWylie <112309453+LeslieWylie@users.noreply.github.com>
|
Updated this branch with current Validation on this head: the existing thinking, agent-region, JSON retry, token-usage, and configuration tests passed; Memory's TypeScript check passed. The dedicated transports still place Qwen's thinking switch in The new-head Linux CLI installer run and Windows Memory validation run both currently report |
…orts Co-authored-by: Codex Signed-off-by: LeslieWylie <112309453+LeslieWylie@users.noreply.github.com>
daabc68 to
7e7726d
Compare
Signed-off-by: LeslieWylie <112309453+LeslieWylie@users.noreply.github.com>
|
@codex review I've kept |
Qwen endpoints served by SGLang and vLLM expect
enable_thinkinginsidechat_template_kwargs. Add explicitsglangandvllmmemory providers so those endpoints receive the control in the right place. The generic OpenAI-compatible provider keeps its existing top-level payload and caller-supplied body options.This branch now includes main's Responses API support. The configuration accepts
openai_responses,sglang, andvllmtogether; Responses requests continue through their own client and receive no automatically added chat-template or thinking fields.The earlier focused CPU validation passed the thinking and protocol-adapter tests (37 passed). It exercised the merged Memory source and AgentSourceCore TypeScript source with the tests' fetch stubs, covering provider configuration, SGLang/vLLM request bodies, the generic provider and Responses isolation. Those behavioral tests were not rerun for this build follow-up.
On head
736cef1e, bothnpm -w @memmy/memory run typecheckandnpm -w @memmy/memory run buildpass through the normal workspace scripts. Each rebuilds AgentSourceCore from this head; the Memory build also completes the viewer, TypeScript output, workspace bridge and CLI assets. The private workspace links resolve to the current source and its newly generated dist, rather than the earlier checkout's compiled output.This uses the existing third-party dependencies with Node 26.7, TypeScript 6.0.3 and Vite 8.0.14, without installing packages or changing shared dependencies. It validates the affected Memory and AgentSourceCore workspaces, not a clean-install reproduction, the entire monorepo, release packaging or new model-server behavior. The existing protocol-test results retain their original scope.
The normal workspace commands were:
The earlier live SGLang replay remains historical evidence. No new model request was made. The external-contributor Linux and Windows workflows currently require maintainer approval; these local checks do not establish their outcome.
Replaces #312. AI assistance: Codex helped resolve the merge and run the focused CPU checks.