Skip to content

fix(cli): bound example archive download time - #2216

Open
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/cli-download-examples-timeout
Open

fix(cli): bound example archive download time#2216
RerankerGuo wants to merge 1 commit into
MemTensor:mainfrom
RerankerGuo:fix/cli-download-examples-timeout

Conversation

@RerankerGuo

Copy link
Copy Markdown
Contributor

Description

memos download_examples downloaded the GitHub archive without a timeout. A stalled connection could therefore block the CLI indefinitely.

This change applies the same bounded-network behavior used elsewhere in the client: the archive request now times out after 30 seconds. The extraction behavior and destination layout are unchanged.

Related Issue (Required): N/A — regression reproduced on current main.

Type of change

  • Bug fix (non-breaking)

How Has This Been Tested?

  • Before: the focused test expected timeout=30 and failed with actual call requests.get(url).
  • After: .venv/bin/pytest tests/test_cli.py -q (6 passed).
  • Ruff check and format pass for both changed files.

Impact

  • Breaking change: no
  • Scope: CLI example archive download only
  • Dependencies: none

@Memtensor-AI Memtensor-AI added area:core MOS 编排层 / 框架底座 / 跨模块问题 status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Aug 5, 2026
@Memtensor-AI
Memtensor-AI requested a review from WeiminLee August 5, 2026 05:51
@Memtensor-AI

Copy link
Copy Markdown
Collaborator

🤖 Open Code Review

Target: PR #2216
Task: cd827644b6e5388c
Base: main
Head: fix/cli-download-examples-timeout

OpenCodeReview: No comments generated. Looks good to me.

Generated by cloud-assistant via Open Code Review.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

✅ Automated Test Results: PASSED

All tests passed (6/6 executed). memos_python_core/changed-repo-python: 6/6. Duration: 5s [advisory, non-gating] AI-generated tests on branch test/auto-gen-cd827644b6e5388c-20260805142955: 20/21 passed, 1 failed — these do NOT affect the PR verdict; review the branch manually.

Branch: fix/cli-download-examples-timeout

@Memtensor-AI Memtensor-AI added status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发 and removed status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core MOS 编排层 / 框架底座 / 跨模块问题 status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants