fix(cli): bound example archive download time - #2216
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Collaborator
🤖 Open Code ReviewTarget: PR #2216 ✅ OpenCodeReview: No comments generated. Looks good to me. Generated by cloud-assistant via Open Code Review. |
Collaborator
✅ Automated Test Results: PASSEDAll tests passed (6/6 executed). memos_python_core/changed-repo-python: 6/6. Duration: 5s [advisory, non-gating] AI-generated tests on branch test/auto-gen-cd827644b6e5388c-20260805142955: 20/21 passed, 1 failed — these do NOT affect the PR verdict; review the branch manually. Branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
memos download_examplesdownloaded the GitHub archive without a timeout. A stalled connection could therefore block the CLI indefinitely.This change applies the same bounded-network behavior used elsewhere in the client: the archive request now times out after 30 seconds. The extraction behavior and destination layout are unchanged.
Related Issue (Required): N/A — regression reproduced on current
main.Type of change
How Has This Been Tested?
timeout=30and failed with actual callrequests.get(url)..venv/bin/pytest tests/test_cli.py -q(6 passed).Impact