Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/memos/configs/mem_cube.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class GeneralMemCubeConfig(BaseMemCubeConfig):
description="User ID for the MemCube. This is used to distinguish between different users' memories.",
)
cube_id: str = Field(
str(uuid.uuid4()),
default_factory=lambda: str(uuid.uuid4()),
description="Cube ID for the MemCube. This is used to distinguish between different MemCubes.",
)
text_mem: MemoryConfigFactory = Field(
Expand Down
2 changes: 1 addition & 1 deletion src/memos/configs/mem_os.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class MOSConfig(BaseConfig):
description="User ID for the MOS. This is used to distinguish between different users' memories.",
)
session_id: str = Field(
default=str(uuid.uuid4()),
default_factory=lambda: str(uuid.uuid4()),
description="Session ID for the MOS. This is used to distinguish between different dialogue",
)
chat_model: LLMConfigFactory = Field(
Expand Down
22 changes: 19 additions & 3 deletions tests/configs/test_mem_cube.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import json

from pathlib import Path

from memos.configs.mem_cube import BaseMemCubeConfig, GeneralMemCubeConfig
from tests.utils import (
check_config_base_class,
Expand All @@ -8,6 +10,9 @@
)


MEM_CUBE_CONFIG_PATH = Path(__file__).resolve().parents[2] / "examples/data/mem_cube_2/config.json"


def test_base_mem_cube_config():
check_config_base_class(
BaseMemCubeConfig,
Expand All @@ -28,13 +33,13 @@ def test_base_mem_cube_config():
def test_general_mem_cube_config():
check_config_base_class(
GeneralMemCubeConfig,
factory_fields=["text_mem", "act_mem", "para_mem", "pref_mem"],
factory_fields=["cube_id", "text_mem", "act_mem", "para_mem", "pref_mem"],
required_fields=[],
optional_fields=["config_filename", "user_id", "cube_id"],
optional_fields=["config_filename", "user_id"],
reserved_fields=["model_schema"],
)

with open("examples/data/mem_cube_2/config.json") as f:
with MEM_CUBE_CONFIG_PATH.open(encoding="utf-8") as f:
config_data = json.load(f)

check_config_instantiation_valid(
Expand All @@ -44,3 +49,14 @@ def test_general_mem_cube_config():

config_data["text_mem"]["backend"] = "kv_cache" # Invalid backend for text_mem
check_config_instantiation_invalid(GeneralMemCubeConfig, config_data)


def test_general_mem_cube_config_generates_unique_default_cube_ids():
with MEM_CUBE_CONFIG_PATH.open(encoding="utf-8") as f:
config_data = json.load(f)
config_data.pop("cube_id", None)

first_config = GeneralMemCubeConfig(**config_data)
second_config = GeneralMemCubeConfig(**config_data)

assert first_config.cube_id != second_config.cube_id
8 changes: 8 additions & 0 deletions tests/configs/test_mem_os.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from memos.configs.mem_os import MOSConfig


def test_mos_config_generates_unique_default_session_ids():
first_config = MOSConfig.model_construct(chat_model=None, mem_reader=None)
second_config = MOSConfig.model_construct(chat_model=None, mem_reader=None)

assert first_config.session_id != second_config.session_id