feat: add harness#1836
Merged
Merged
Conversation
Memtensor-AI
pushed a commit
that referenced
this pull request
Jun 2, 2026
Co-authored-by: harvey_xiang <harvey_xiang22@163.com>
syzsunshine219
pushed a commit
that referenced
this pull request
Jun 2, 2026
…1861) * fix: respect autoInstall=false by removing install_recommended bypass When skillEvolution.autoInstall is set to false, the install_recommended path in autoInstallIfNeeded() was still triggering automatic installation. This fix ensures autoInstall=false completely disables all auto-install behavior. Closes #1398 Co-authored-by: Cursor <cursoragent@cursor.com> * feat: add harness (#1836) Co-authored-by: harvey_xiang <harvey_xiang22@163.com> * chore: update gitignore * fix: respect autoInstall: false config in all auto-install paths - Remove install_recommended bypass that ignored autoInstall config - Consolidate logic: check autoInstall once at method entry - Add unit tests verifying autoInstall: false blocks all installations Fixes #1398 * fix: respect autoInstall=false config in skill evolution - Fix autoInstallIfNeeded to skip ALL auto-installation when autoInstall=false - Previously install_recommended path bypassed autoInstall config check - Add comprehensive test coverage for autoInstall behavior (false/true/default) - Closes #1398 --------- Co-authored-by: jiachengzhen <jiacz@memtensor.cn> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: HarveyXiang <harvey_xiang@163.com> Co-authored-by: harvey_xiang <harvey_xiang22@163.com> Co-authored-by: MemOS AutoDev <autodev@memos.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the problem it solves, the implementation approach, and relevant context. List any dependencies required for this change.
Related Issue (Required): Fixes #issue_number
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Reviewer Checklist