Skip to content

Studio UX integration: step picker, summary preview triage, variable-browser polish - #76

Closed
KFilippopolitis wants to merge 22 commits into
masterfrom
integration/studio-ux-2026-11-11
Closed

KFilippopolitis wants to merge 22 commits into
masterfrom
integration/studio-ux-2026-11-11

Conversation

@KFilippopolitis

Copy link
Copy Markdown
Contributor

Merges the three November 11 studio-UX jobs and the federated preprocessing foundations into master.

Jobs integrated

  • job/2026-11-11_add-step-picker-ux (6d0a47b) — step picker, add rows and grouped menus (a740918)
  • job/2026-11-11_summary-preview-triage-ux (ba09367) — summary rail triage + statistics table, no duplicate "All datasets" column (d005f5f)
  • job/2026-11-11_variable-browser-views-polish (3ae71f0) — variable-browser views + exploration polish (89b51d9)
  • feat/preprocessing-steps-ui (255fd6c) — content fully included (7 content commits on the job branch; the merge commit itself is content-free)

Also includes 61bbada (dead-code check ignores *.testing.ts spec helpers) and 995f274 (e2e helper study-chip fix).

Merge of current master (f61e4db, studio-feedback-round)

  • Merged origin/master into the integration branch (053b312) and resolved 2 conflicts:
    • zoomable-circle-packing.ts: kept integration's label-fit engine (fitBubbleLabel/pickVisibleLabels) combined with master's partially-available semantics (amber PARTIAL_AVAILABILITY_FILL, pointer/clickable, no aria-disabled). Unused unavailable param kept as _unavailable for call-site compat.
    • statistic-analysis-panel.component.html header copy: master's wording.
  • Fixed a merge-induced break: ontology-tree-browser template uses pluralize() (master) but the component only exposed groupContentsLabel; re-added the import+exposure.
  • Added missing genericCatalogSteps/genericStepDroppedCodes mocks to master's 3 specs (they predated those service methods).
  • Removed the categorical card's 'Otherwise' fallback row (records matching no rule get no value), matching transformation-open.spec.ts intent.

Validation

  • npm run verify — typecheck + dead-code (0) + build: green (2 pre-existing warnings, also on master).
  • npm test -- --watch=false — 106 files / 1358 tests passed.
  • No commits pushed directly to master; this PR is integration -> master only.

Requires human review before merge (copy changes, chart semantics).

# Conflicts:
#	src/app/pages/experiment-studio/statistic-analysis-panel/statistic-analysis-panel.component.ts
…a grouped menu

# Conflicts:
#	src/app/pages/experiment-studio/statistic-analysis-panel/statistic-analysis-panel.component.ts
…nd never overlap

# Conflicts:
#	src/app/pages/experiment-studio/visualisations/bubble-chart/zoomable-circle-packing.ts
…t, sort by missing, arrow keys, search that never dead-ends

# Conflicts:
#	src/app/pages/experiment-studio/statistic-analysis-panel/statistic-analysis-panel.component.ts
…atasets" column, sized to its columns

# Conflicts:
#	src/app/pages/experiment-studio/statistic-analysis-panel/statistic-analysis-panel.component.ts
- Add missing genericCatalogSteps / genericStepDroppedCodes mocks to the
  three specs brought in by origin/master (they predated those service
  methods; the component calls them unconditionally).
- Pipeline header copy and Raw-data subtitle follow master's wording
  ('Get your selected data…', 'descriptive statistics of your unprocessed
  selected variables') — the integration branch had already rewritten the
  header, so the stranded specs never matched either copy.
- Remove the 'Otherwise' fallback row from the categorical card (and its
  '+ fallback' suffix): records matching no rule get no value. This matches
  the intent statement in transformation-open.spec.ts and the behavior the
  integration branch chose (7c799ce).
…e catalog

(rebased onto current origin/master; conflicts resolved in favour of the
merged 2026-11-10 studio feedback round copy)
…e transforms

(rebased onto current origin/master)
@KFilippopolitis
KFilippopolitis force-pushed the integration/studio-ux-2026-11-11 branch from 25fc774 to 915b8c1 Compare November 11, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant