Repository navigation
feat: UI support for federated preprocessing steps - #73
Merged
Merged
Conversation
| const source = step === 'transform' ? transformStrategies : scalerStrategies; | ||
| const codes = this.outlierPreprocessingVariables.map((v) => v.code); | ||
| return JSON.stringify({ | ||
| strategies: Object.fromEntries(codes.sort().map((code) => [code, source[code] ?? null])), |
KFilippopolitis
added a commit
that referenced
this pull request
Nov 9, 2026
Review follow-ups on #73: - The transform and scaling stations, their rail nodes and ghost add rows are shown only while the catalog lists the step (optimistically before the catalog loads, like the creators), and the steps are dropped from every request once the catalog loads without them — exaflow rejects unknown steps with 'Transformer does not exist.' - The scaler step is dropped from a filtered request when no strategy survives, instead of a lone step-level feature_range keeping it - The minmax feature range now rides on the min-max summary lines only - Component spec coverage: most_frequent nominal-only gate, station availability against the catalog, pending/applied strategy lifecycle
Implements the platform-ui tasks from the federated preprocessing spec (step names are the proposal: variable_transformer / variable_scaler; replace them if exaflow ships different ones): - most_frequent imputation for nominal variables (editor, validation, summary label, valid-action check); mean/median stay numerical-only - New per-variable transform station (log1p, sqrt, asinh, yeo_johnson, quantile_uniform, quantile_normal) with domain-limit notes for log1p/sqrt read off the loaded describe - New per-variable scaling station (standard, robust, minmax with feature_range, maxabs) - Rail sub-nodes, ghost add rows, batch menus, doc panels, hydration of saved experiments, and Remove for both new stations - Request building: variable filtering for the new steps, rail order (impute, clip, transform, scale), summary entries feeding experiment detail and PDF/CSV export - Specs: request shape, filtering, step order, summary text, restore
Review follow-ups on #73: - The transform and scaling stations, their rail nodes and ghost add rows are shown only while the catalog lists the step (optimistically before the catalog loads, like the creators), and the steps are dropped from every request once the catalog loads without them — exaflow rejects unknown steps with 'Transformer does not exist.' - The scaler step is dropped from a filtered request when no strategy survives, instead of a lone step-level feature_range keeping it - The minmax feature range now rides on the min-max summary lines only - Component spec coverage: most_frequent nominal-only gate, station availability against the catalog, pending/applied strategy lifecycle
Current exaflow fills each dataset with its own local mode; no CDE vocabulary is used yet. Say so in the gate comment instead of 'the vocabulary comes from the CDE on the worker side'.
KFilippopolitis
force-pushed
the
feat/federated-preprocessing-ui
branch
from
November 9, 2026 17:49
cb6ae56 to
34c5859
Compare
KFilippopolitis
added a commit
that referenced
this pull request
Nov 9, 2026
Review follow-ups on #73: - The transform and scaling stations, their rail nodes and ghost add rows are shown only while the catalog lists the step (optimistically before the catalog loads, like the creators), and the steps are dropped from every request once the catalog loads without them — exaflow rejects unknown steps with 'Transformer does not exist.' - The scaler step is dropped from a filtered request when no strategy survives, instead of a lone step-level feature_range keeping it - The minmax feature range now rides on the min-max summary lines only - Component spec coverage: most_frequent nominal-only gate, station availability against the catalog, pending/applied strategy lifecycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the platform-ui tasks from the federated preprocessing spec (Obsidian: platform-ui should do). The proposal step names are used as-is —
variable_transformer/variable_scaler; a rename follow-up exists for when exaflow fixes the names.most_frequentimputation for nominal variables only (mean/median remain numerical-only); wired into the editor, the valid-action check, validation, and the run summary. No category list is sent — the vocabulary stays on the worker side.variable_transformer): new per-variable station — log1p, sqrt, asinh, Yeo-Johnson, quantile→uniform, quantile→normal — with a batch "set all" menu and spec documentation panel. Domain-limit notes for log1p/sqrt check the observed minimum from the loaded describe (the plan's CDEminValueis not exposed to the UI; noted as a deviation — exaflow still enforces the real limit with a 400 that the apply footer shows as it comes).variable_scaler): new per-variable station — standard, robust, minmax (withfeature_rangeinputs), maxabs.Catalog gate (merge safety)
The transform/scaling stations, their rail nodes and add rows are shown only while the catalog lists the step (optimistically before the catalog loads, like the creators), and the steps are dropped from every request once the catalog loads without them. Exaflow rejects unknown steps with
Transformer '<name>' does not exist., so:Files changed
src/app/pages/experiment-studio/statistic-analysis-panel/statistic-analysis-panel.component.ts/.html— two new stations, rail sub-nodes + ghost add-rows, batch menus, hydration of saved experiments,most_frequent, catalog gatingsrc/app/services/experiment-studio.service.ts— summary entries, strategy labels, variable filtering (with the feature_range-only drop), request-level catalog gateexperiment-studio.service.spec.ts,statistic-analysis-panel.pipeline.spec.ts,statistic-analysis-panel.component.spec.ts— new coverageTests / checks
npm test -- --watch=false— 1160/1160 passing. New tests cover request shape, variable filtering, step order, summary text, restore, the catalog gate (hidden stations + dropped request steps), the scaler filter's feature_range case, and themost_frequentnominal-only gate; the component spec was extended (134 tests there).npm run verify(typecheck + dead-code scan + build) — passingRisk