Skip to content

chore(appprojects): scope AppProjects to least privilege - #13

Merged
jdaln merged 3 commits into
mainfrom
chore/appprojects-scope-least-privilege
May 26, 2026
Merged

jdaln merged 3 commits into
mainfrom
chore/appprojects-scope-least-privilege

Conversation

@jdaln

@jdaln jdaln commented May 26, 2026

Copy link
Copy Markdown
Contributor

Squashes:

  • chore(mip-common): explicitly disallow namespace RBAC
  • chore(mip-federations): scope umbrella project to Application-only
  • chore(appprojects): remove unused mip-argo-project-shared-apps
  • chore(appprojects): add explicit RBAC blacklist + drift lint

Squashes:
- chore(mip-common): explicitly disallow namespace RBAC
- chore(mip-federations): scope umbrella project to Application-only
- chore(appprojects): remove unused mip-argo-project-shared-apps
- chore(appprojects): add explicit RBAC blacklist + drift lint

(cherry picked from commit 06bc70ba5455d65ee8c2fe2b257868c03b0dec60)
Copilot AI review requested due to automatic review settings May 26, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens Argo CD AppProject permissions to follow least-privilege by scoping projects to Application-only where appropriate, explicitly denying namespaced RBAC management in static projects, and removing an unused shared-apps AppProject.

Changes:

  • Removed the unused mip-argo-project-shared-apps static AppProject and its ApplicationSet entry.
  • Scoped the federations “umbrella” AppProject down to Application resources and the Argo CD namespace destination only.
  • Added explicit namespaceResourceBlacklist entries for Role/RoleBinding and introduced a pre-commit drift check (with an opt-out marker for Submariner).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
projects/static/submariner/submariner-project.yaml Documents and opts out of RBAC drift lint due to legitimate namespaced RBAC needs.
projects/static/mip-shared-apps/mip-shared-apps.yaml Removes unused shared-apps AppProject definition.
projects/static/mip-shared-apps/kustomization.yaml Removes kustomization for the deleted shared-apps AppProject.
projects/static/mip-security/mip-security.yaml Explicitly blacklists namespaced RBAC resources.
projects/static/mip-federations/mip-federations.yaml Scopes umbrella project to Application-only + adds RBAC blacklist.
projects/static/mip-common/mip-common.yaml Removes RBAC from whitelist and explicitly blacklists it.
base/argo-projects.yaml Removes shared-apps AppProject from the static AppProjects ApplicationSet.
.githooks/pre-commit Adds an RBAC blacklist drift check for static AppProjects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .githooks/pre-commit Resolved
Comment thread .githooks/pre-commit Resolved
@jdaln
jdaln force-pushed the chore/appprojects-scope-least-privilege branch from 9e85c48 to a9eadc2 Compare May 26, 2026 15:57
@jdaln
jdaln requested a review from KFilippopolitis May 26, 2026 16:03
@jdaln
jdaln merged commit 43eb3dd into main May 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants