Repository navigation
chore(appprojects): scope AppProjects to least privilege - #13
Merged
Merged
Conversation
Squashes: - chore(mip-common): explicitly disallow namespace RBAC - chore(mip-federations): scope umbrella project to Application-only - chore(appprojects): remove unused mip-argo-project-shared-apps - chore(appprojects): add explicit RBAC blacklist + drift lint (cherry picked from commit 06bc70ba5455d65ee8c2fe2b257868c03b0dec60)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens Argo CD AppProject permissions to follow least-privilege by scoping projects to Application-only where appropriate, explicitly denying namespaced RBAC management in static projects, and removing an unused shared-apps AppProject.
Changes:
- Removed the unused
mip-argo-project-shared-appsstatic AppProject and its ApplicationSet entry. - Scoped the federations “umbrella” AppProject down to
Applicationresources and the Argo CD namespace destination only. - Added explicit
namespaceResourceBlacklistentries forRole/RoleBindingand introduced a pre-commit drift check (with an opt-out marker for Submariner).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/static/submariner/submariner-project.yaml | Documents and opts out of RBAC drift lint due to legitimate namespaced RBAC needs. |
| projects/static/mip-shared-apps/mip-shared-apps.yaml | Removes unused shared-apps AppProject definition. |
| projects/static/mip-shared-apps/kustomization.yaml | Removes kustomization for the deleted shared-apps AppProject. |
| projects/static/mip-security/mip-security.yaml | Explicitly blacklists namespaced RBAC resources. |
| projects/static/mip-federations/mip-federations.yaml | Scopes umbrella project to Application-only + adds RBAC blacklist. |
| projects/static/mip-common/mip-common.yaml | Removes RBAC from whitelist and explicitly blacklists it. |
| base/argo-projects.yaml | Removes shared-apps AppProject from the static AppProjects ApplicationSet. |
| .githooks/pre-commit | Adds an RBAC blacklist drift check for static AppProjects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… role and binding validation
jdaln
force-pushed
the
chore/appprojects-scope-least-privilege
branch
from
May 26, 2026 15:57
9e85c48 to
a9eadc2
Compare
KFilippopolitis
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squashes: