Skip to content

feat(editor): safely edit existing PDF text - #114

Closed
McanKul wants to merge 1 commit into
developmentfrom
feat/edit-existing-pdf-text
Closed

McanKul wants to merge 1 commit into
developmentfrom
feat/edit-existing-pdf-text

Conversation

@McanKul

@McanKul McanKul commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a bounded source-content classifier and existing-text editing UI
  • preserve original files and reject stale, malformed, encrypted, signed, or unsupported content explicitly
  • verify previews and saved output with independent qpdf/Poppler checks before publish
  • document the supported subset, fixtures, limits, and release behavior
  • require PDF engines in CI so coverage cannot silently skip

This completes the v0.4 direct-editing foundation without promising Word-style reflow or universal PDF support. Existing image replacement remains unsupported and is reported honestly.

Verification

  • npm run check:versions
  • npm run build
  • npm test — 60 files, 583 tests passed
  • cargo check --manifest-path src-tauri/Cargo.toml
  • OFFPDF_REQUIRE_ENGINES=1 cargo test --manifest-path src-tauri/Cargo.toml --lib -- --nocapture — 846 passed, 0 failed, 6 ignored, 0 skipped for missing engines

Closes #11
Closes #12
Closes #33

@McanKul

McanKul commented Oct 4, 2026

Copy link
Copy Markdown
Owner Author

Closing this PR so the text-editing work can be reorganized into smaller, reviewable changes. Nothing from this branch has been merged.

@McanKul McanKul closed this Oct 4, 2026
@McanKul
McanKul deleted the feat/edit-existing-pdf-text branch October 4, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant