Switch generate_psa_test.py to automatic dependencies for negative test cases#9909
Merged
davidhorstmann-arm merged 4 commits intoJan 21, 2025
Conversation
gilles-peskine-arm
added
component-crypto
gilles-peskine-arm
force-pushed
the
psa-storage-test-cases-never-supported-negative-dev
branch
3 times, most recently
from
cd14308 to
87c49c3
Compare
gilles-peskine-arm
added
needs-review
davidhorstmann-arm
previously approved these changes
Jan 20, 2025
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
Catch up with Mbed-TLS/mbedtls-framework#104 = "Switch generate_psa_test.py to automatic dependencies for negative test cases" Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
dismissed stale reviews from davidhorstmann-arm and waleed-elmelegy-arm
via
13c418d
gilles-peskine-arm
force-pushed
the
psa-storage-test-cases-never-supported-negative-dev
branch
from
87c49c3 to
13c418d
Compare
Contributor
Author
|
I rebased on top of This will need one more rewrite of the submodule-updating commit after Mbed-TLS/TF-PSA-Crypto#157 is merged. |
gilles-peskine-arm
added
needs-ci
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Contributor
Author
|
And here's the last submodule update, with Mbed-TLS/TF-PSA-Crypto#157 merged. |
gilles-peskine-arm
requested review from
davidhorstmann-arm and
waleed-elmelegy-arm
gilles-peskine-arm
added
needs-review
waleed-elmelegy-arm
approved these changes
Jan 21, 2025
waleed-elmelegy-arm
added
approved
davidhorstmann-arm
approved these changes
Jan 21, 2025
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the forward port of #9025. Everything is happening in the submodules, except for removing the exceptions to test coverage that this is fixing.
PR checklist