PSA interruptible sign/verify: detect invalid curve family in start#9890
Merged
Conversation
Detect attempts to do ECDSA with a Montgomery curve in psa_sign_hash_start() and psa_verify_hash_start(), whereas before start() would succeed and complete() would fail. This avoids an inconsistency between psa_sign_hash() and psa_sign_hash_start() that would be annoying to handle in test_suite_psa_crypto_op_fail. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
component-crypto
Merged
6 tasks
gilles-peskine-arm
requested review from
davidhorstmann-arm and
waleed-elmelegy-arm
gilles-peskine-arm
added
needs-review
davidhorstmann-arm
approved these changes
Jan 15, 2025
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
davidhorstmann-arm
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mbed-TLS/mbedtls-framework#104 fixes a bug whereby some negative tests were always skipped (because they were generated with incorrect dependencies). These test cases fail because the test code is more strict about error behavior than the library. Make the library detect some errors earlier to reconcile it with the test code.
Once this is merged, the CI on Mbed-TLS/mbedtls-framework#104 should pass.
PR checklist