Publish docker images built on the new CI to Dockerhub#240
Open
bensze01 wants to merge 3 commits into
Open
Conversation
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Also adopt a new format for them that includes the architecture. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
dev/bensze01/publish-to-dockerhub
branch
from
a3f0dbd to
e819974
Compare
One less place we have to keep in sync.. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
dev/bensze01/publish-to-dockerhub
branch
from
e819974 to
c3cd8e6
Compare
github-project-automation
Bot
moved this to In Development
in Roadmap pull requests (new board)
bensze01
moved this from In Development
to In Review
in Roadmap pull requests (new board)
gilles-peskine-arm
requested changes
Dec 16, 2025
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me on code inspection, except doesn't this publish the arm-compilers image?
| docker push $common.docker_repo:$tag | ||
| docker push $common.docker_repo:$cache | ||
| # Push the image to the public Dockerhub repo | ||
| docker push $common.docker_repo_name:$tag |
Contributor
There was a problem hiding this comment.
I thought we weren't supposed to publish the arm-compilers image?
Contributor
Author
There was a problem hiding this comment.
My understanding is that we are OK to publish arm-compilers, as long as the image doesn't include third party software we can't redistribute.
The compiler itself is not usable without a license server / valid license file.
It is the status quo WRT the Linaro-hosted Open CI either way.
github-project-automation
Bot
moved this from In Review
to In Development
in Roadmap pull requests (new board)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add the missing images to the dockerfile-builder job.
CI run: