Skip to content

c_build_helper: Split cc command line #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OldManYellsAtCloud wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

c_build_helper: Split cc command line #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/mbedtls_framework/c_build_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def compile_c_file(c_filename, exe_filename, include_dirs):
cc = os.getenv('HOSTCC', None)
if cc is None:
cc = os.getenv('CC', 'cc')
cmd = [cc]
cmd = cc.split()

@gilles-peskine-arm gilles-peskine-arm Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC is commonly interpolated in a shell command line, so maybe we should go further and construct a shell command? If we do so then we should quote the file names and include directories for shell expansion in case they contain full paths that contain spaces or other special characters.

@OldManYellsAtCloud OldManYellsAtCloud May 2, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I'm not really sure what you are asking, what should I change - I was only trying to package the latest version only for Yocto. But if you could point me to an example where such a shell command is done already, I could definitely try doing something similar.


proc = subprocess.Popen(cmd,
stdout=subprocess.DEVNULL,
Expand Down