Skip to content

Print a call stack trace on all.sh failure #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilles-peskine-arm wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

Print a call stack trace on all.sh failure #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions scripts/all-core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,18 @@ pre_setup_keep_going () {
esac
}

## call_stack [NUMBER_OF_FRAMES_TO_OMIT]
## Print a function call stack.
## Start at the caller of this function, or $1 frames further up.
## Stop just before run_component.
call_stack () {
local i=$((${1:-0} + 1)) filename=
while [[ $i -lt ${#FUNCNAME[@]} && ${FUNCNAME[$i]} != run_component ]]; do
echo " ^ ${BASH_SOURCE[$i]#$PWD/}:${BASH_LINENO[$((i-1))]}:${FUNCNAME[$i]}"
((++i))
done
}

# This function runs if there is any error in a component.
# It must either exit with a nonzero status, or set
# last_failure_status to a nonzero value.
Expand Down Expand Up @@ -773,6 +785,7 @@ pre_setup_keep_going () {
text="$current_section: $failed_command -> $last_failure_status"
echo "${start_red}^^^^$text^^^^${end_color}" >&2
echo "$text" >>"$failure_summary_file"
call_stack 1

# If the command is fatal (configure or build command), stop this
# component. Otherwise (test command) keep the component running
Expand Down