Move psasim into framework#238
Conversation
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
Update crypto pointer to development-restricted
Signed-off-by: Felix Conway <felix.conway@arm.com>
Update framework pointer to fix CI for generated tests
This will be needed when we change how many times some functions are callled in ecp.c, making them more susceptible to inlining. Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
[dev] Make test more robust
…rge-public-20250916 Conflicts: * `tf-psa-crypto`: updated to the merge of `development` and `development-restricted`.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
…erge-public-20250916 mbedtls: : merge public into restricted 2025-09-16
This commit restores all changelog entries between the mbedtls-3.6.0 tag and the mbedtls-4.0.0-beta tag. git diff ce4683e..09dc57d --name-status -- ChangeLog.d Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
ripgrep was used to check against the
tf-psa-crypto.v1.0.0-beta Changelog.
rg --multiline -F -f {changelog_to_check}.txt -o ../tf-psa-crypto-ChangeLog
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
…ser-mbedtls Fix non-determinism when generating mbedtls_config_check_user.h
Split crypto part of Mbed TLS makefiles
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
…-prep2 SHA3 cleanup prep: Adapt to the split of test_suite_shax
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
…o-framework Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
4881510 to
f51cf54
Compare
|
This PR was created again based on latest development and using the mbedtls-move-to-framework. The command used to create is are: Eventually the script will break because it is impossible to automatically merge the branch into the framework. In addition to the reasons for doing so discussed above I noticed that we did not migrate the history of framework/psasim on the mbedtls side. Git does not allow stacking explicitly different git histories for a file on the same tree and even if we merge the histories the --follow will only take the latest path. Also when trying to merge it will be incorrectly import the wrong state of some files. The process now is:
Merge conflict resolution |
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
At fc4689b, looks good to me for moving psasim while preserving the history in the mbedtls repository up to 0294b11.
The commit message d982361 is inaccurate (it's not yet moving anything to the framework, and it's also removing files, not just moving them), but that's not worth redoing the merge.
I'll submit another review for the subsequent code changes.
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM at f51cf54
| # 2) Mbed TLS's version of psa-client-server | ||
| # 3) Fallback to the framework location (default after move) | ||
| if [ -z "${PSASIM_PATH+set}" ]; then | ||
| if [ -d tests/psa-client-server ]; then |
There was a problem hiding this comment.
Why not test for tests/psa-client-server/psasim, since that's what we care about?
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I've checked that the new psasim directory is consistent with mbedtls (except for a path change) and that the subsequent changes make sense.
Description
Part of the work required by Mbed-TLS/mbedtls#10487. Psasim was originally placed in framework directory, but moved to mbedtls while we were workign on it. Now this PR is migrating it back, while preserving the history