Repository navigation
Conversation
Sixteen statics held state outside tests. The quota and secret regexes now live in QuotaPatterns and SecretPatterns on the daemon state and the TUI app; the syntax set, theme and tunnel regex in the chat stream's assets, built once at TUI start; the repo-search client and the per-repository land locks in SharedServices on the daemon state, passed to every session's commands; the chat revision counter in a clock successor streams share; the jank threshold is read once at startup. The crash handler keeps its two statics, which a sigaction handler can only reach that way. Closes #1158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sixteen
staticitems held state outside tests. Each now lives with the value that already owns it and is passed to its users: the quota and secret regexes inQuotaPatternsandSecretPatternson the daemon state and the TUI app; the syntax set, theme and tunnel regex in the chat stream's assets, built once when the TUI starts; the repo-search client and the per-repository land locks inSharedServiceson the daemon state, so every session still shares one lock per repository; the chat revision counter in a clock that a replacement stream shares, so revisions stay unique for the layout cache; the jank threshold read once at startup. The crash handler keeps its two statics, since asigactionhandler gets no context pointer.The highlighter still compiles the theme's selectors once, not per line. Clippy is clean with
-D warningsand 801 tests across quota, secrets, the TUI, repo search, PRs, terminal commands, bash and the daemon pass.Closes #1158