Repository navigation
Conversation
A session PR's state was a String from the prs row to the sidebar, compared against literals in pr.rs, the database layer, the daemon and the TUI. PrState now carries it, stored and sent under the same snake_case names, with is_terminal, is_live and is_in_flight replacing each string match, and pr list --state parses into PrFilter. No state string is left in SQL. Closes #1161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A session PR's state was a
Stringfrom theprsrow to the sidebar, matched against literals acrosspr.rs, the database layer, the daemon and the TUI, so a misspelt state compiled and matched nothing.PrStatenow carries it, stored and serialized under the samesnake_casenames so existing rows and the wire format are unchanged, withis_terminal,is_liveandis_in_flightin place of each string match.pr list --stateparses intoPrFilter, whereopenkeeps selecting every non-terminal PR, and the SQL that filtered on state lists now filters through the predicates.Round-trip tests cover each stored string and its JSON; the pr, db, daemon, IPC, client and sidebar tests pass and clippy is clean with
-D warnings.Closes #1161