Repository navigation
fix(openai): classify a rate limit reported mid-stream as transient - #776
Merged
Merged
Conversation
The Responses `error` and `response.failed` events kept only their message, so every failure they reported was permanent and a rate limit that resets in seconds ended the run. Both now keep their code (the failure sits under `response.error` on `response.failed`), and `rate_limit_exceeded` classifies as transient wherever it arrives. Closes #775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses
errorandresponse.failedevents now keep theircode, read fromresponse.erroronresponse.failedas the API places it, andrate_limit_exceededis transient wherever it arrives, so the caller's retry policy handles a limit reported after the stream started. A scripted-server test covers both Responses events and the chat-completions error object; aither-openai's clippy and tests pass.Closes #775