Repository navigation
fix(release): never publish aither-sed and aither-patch - #774
Merged
Merged
Conversation
Both were deleted from crates.io and now ship from May; the release would otherwise try to publish them and fail, since a first publish needs a token the trusted-publishing workflow does not have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both crates were deleted from crates.io, and their programs now ship from May. The open release PR still bumps them, and publishing them would fail: a first publish needs an API token, and the release workflow authenticates only through trusted publishing.
publish = falsetakes them out of every release. Removing the crates themselves stays with #736.Closes #773