Skip to content

Repository navigation

refactor: update ConversationSweeper constructor to use IServiceProvider #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatthewHsu1 merged 1 commit into from
Sep 21, 2026
Merged

refactor: update ConversationSweeper constructor to use IServiceProvider #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/AgentCore.AspNetCore/Conversation/ConversationSweeper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using AgentCore.Application.Ports;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
Expand All @@ -13,7 +14,7 @@ namespace AgentCore.AspNetCore.Conversation
/// calling <c>AddConversationSweep</c>. Without that call, conversations are kept forever.
/// </remarks>
public sealed class ConversationSweeper(
IConversations conversations,
IServiceProvider services,
IOptions<ConversationSweepOptions> options,
TimeProvider timeProvider,
ILogger<ConversationSweeper> logger) : BackgroundService
Expand All @@ -23,6 +24,9 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
{
ConversationSweepOptions settings = options.Value;

// Hosted service is constructed before AgentCore's own boot has not finished.
IConversations conversations = services.GetRequiredService<IConversations>();

using PeriodicTimer timer = new(settings.Interval, timeProvider);

while (await timer.WaitForNextTickAsync(stoppingToken).ConfigureAwait(false))
Expand Down
2 changes: 1 addition & 1 deletion src/AgentCore.AspNetCore/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,5 @@ AgentCore.AspNetCore.Conversation.ConversationSweepOptions.Interval.set -> void
AgentCore.AspNetCore.Conversation.ConversationSweepOptions.BatchSize.get -> int
AgentCore.AspNetCore.Conversation.ConversationSweepOptions.BatchSize.set -> void
AgentCore.AspNetCore.Conversation.ConversationSweeper
AgentCore.AspNetCore.Conversation.ConversationSweeper.ConversationSweeper(AgentCore.Application.Ports.IConversations! conversations, Microsoft.Extensions.Options.IOptions<AgentCore.AspNetCore.Conversation.ConversationSweepOptions!>! options, System.TimeProvider! timeProvider, Microsoft.Extensions.Logging.ILogger<AgentCore.AspNetCore.Conversation.ConversationSweeper!>! logger) -> void
AgentCore.AspNetCore.Conversation.ConversationSweeper.ConversationSweeper(System.IServiceProvider! services, Microsoft.Extensions.Options.IOptions<AgentCore.AspNetCore.Conversation.ConversationSweepOptions!>! options, System.TimeProvider! timeProvider, Microsoft.Extensions.Logging.ILogger<AgentCore.AspNetCore.Conversation.ConversationSweeper!>! logger) -> void
static AgentCore.AspNetCore.DependencyInjection.AgentCoreServiceCollectionExtensions.AddConversationSweep(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<AgentCore.AspNetCore.Conversation.ConversationSweepOptions!>? configure = null) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
Loading