[1.x] KaxDefines: do not allow infinite sizes on all Master elements except Segment+Cluster#234
Open
robUx4 wants to merge 1 commit into
Open
[1.x] KaxDefines: do not allow infinite sizes on all Master elements except Segment+Cluster#234robUx4 wants to merge 1 commit into
robUx4 wants to merge 1 commit into
Conversation
… Segment+Cluster Only Segment [^1] and Clusters [^2] are allowed to be infinite. [^1]: https://www.rfc-editor.org/rfc/rfc9559#section-5.1 [^2]: https://www.rfc-editor.org/rfc/rfc9559#section-5.1.3
robUx4
added
the
abi-break
ePirat
pushed a commit
to videolan/vlc
that referenced
this pull request
Apr 30, 2026
This will allow false detection of an EBML elements. Only Segment [^1] and Clusters [^2] are allowed to be infinite and they use a different macro. Submitted upstream [^3] but will need a new release as it might break the ABI. Ref. #29578 [^1]: https://www.rfc-editor.org/rfc/rfc9559#section-5.1 [^2]: https://www.rfc-editor.org/rfc/rfc9559#section-5.1.3 [^3]: Matroska-Org/libmatroska#234
ePirat
pushed a commit
to videolan/vlc
that referenced
this pull request
May 7, 2026
This will allow false detection of an EBML elements. Only Segment [^1] and Clusters [^2] are allowed to be infinite and they use a different macro. Submitted upstream [^3] but will need a new release as it might break the ABI. Ref. #29578 [^1]: https://www.rfc-editor.org/rfc/rfc9559#section-5.1 [^2]: https://www.rfc-editor.org/rfc/rfc9559#section-5.1.3 [^3]: Matroska-Org/libmatroska#234 (cherry picked from commit f2d8e61) Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only Segment 1 and Clusters 2 are allowed to be infinite.
They both use the
DECLARE_MKX_MASTER_CONS()macro and are the only ones to use them.Footnotes
https://www.rfc-editor.org/rfc/rfc9559#section-5.1 ↩
https://www.rfc-editor.org/rfc/rfc9559#section-5.1.3 ↩