[1.x] CMake: check actually needed system headers are used #333
Merged
Conversation
This triggers more compilation warning. It is not on by default so the code will keep building without new warning in the future. It is meant for developers of the library to produce cleaner code and/or detect issues early. (cherry picked from commit fd4ad0c)
And make sure clang doesn't pretend to use compiler flags when it just ignores them. (cherry picked from commit 8c3ae20)
Most of the have already been fixed. Signed-off-by: Rosen Penev <rosenp@gmail.com> (cherry picked from commit 3a015a4)
They are very noisy and not very useful. the list of warnings can be found at https://learn.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default (cherry picked from commit f9af4fd)
If the compiler complains we should handle it. (cherry picked from commit 802880a)
In dev mode. So CI builds must pass with this mode on. LIBCPP_REMOVE_TRANSITIVE_INCLUDES is a libc++ thing. (cherry picked from commit cb754b9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.