Add missing includes#329
Merged
Merged
Conversation
This file uses std::nothrow, which requires including <new>. This fixes building with libc++ with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES set (which removes unnecessary transitive dependencies, making it more strict wrt including all the right headers). This will become the default in a few versions, see [1]. This is only needed since commit 0d5873f. Older versions before b5475c3 require an extra include of <iterator> in src/EbmlMaster.cpp. [1] https://discourse.llvm.org/t/rfc-remove-unused-transitive-includes-from-the-libc-headers/90157
This was referenced May 2, 2026
Contributor
|
Not that this branch is the development branch and is not used (or shouldn't be) anywhere. The used branch is the v1.x one. I did a similar version for that branch in #334 with the issues I found with LLVM 22. GCC has also been going in the same direction so we definitely need to fix these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file uses std::nothrow, which requires including
<new>.This fixes building with libc++ with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES set (which removes unnecessary transitive dependencies, making it more strict wrt including all the right headers). This will become the default in a few versions, see [1].
This is only needed since commit 0d5873f. Older versions before b5475c3 require an extra include of in src/EbmlMaster.cpp.
[1] https://discourse.llvm.org/t/rfc-remove-unused-transitive-includes-from-the-libc-headers/90157