Skip to content
This repository was archived by the owner on Aug 24, 2025. It is now read-only.

Mirror implementation of new database system from main Skript plugin#96

Open
MotikaCraft-TheJoshua wants to merge 29 commits into
Matocolotoe:masterfrom
MotikaCraft-TheJoshua:master
Open

Mirror implementation of new database system from main Skript plugin#96
MotikaCraft-TheJoshua wants to merge 29 commits into
Matocolotoe:masterfrom
MotikaCraft-TheJoshua:master

Conversation

@MotikaCraft-TheJoshua
Copy link
Copy Markdown

Description

Simply mirrored implementation of new database system which works perfectly (but requires thorough/long-term testing) on main Skript repo at https://github.com/SkriptLang/Skript/tree/enhancement/sql or to be precise - https://github.com/SkriptLang/Skript/actions?page=3&query=branch%3Aenhancement%2Fsql - at these builds

  • Mirrored most of the changes found at Get SQL databases working again SkriptLang/Skript#5646
  • Tested for probably 2-3 hours using default and having 1 main database for cross-server connection and variables with multiple monitor changes timespan (default, 10sec, 5sec), ran:
    • 1.8.8 Carbon(Spigot) server fork of Paper using this fork with changes from my forked version of it.
    • 1.8.8 PandaSpigot server fork of Paper using this fork with changes from my forked version of it.
    • 1.8.8 WindSpigot server fork of Paper using this fork with changes from my forked version of it.
    • 1.8.8 FlamePaper server fork of Paper using this fork with changes from my forked version of it.

After some time of testing things around with this, i can confirm that this runs stable, feel free to try it yourself (anyone who is reading this/curious), builds can be found at Actions in my fork.

* Note1: All 1.8 forks used for testing are forks that are not so different from paper but updated to latest libraries (log4j/netty/mysql) and similar stuff which should natively be inside of paper 1.8 even before it was abandoned, nothing more than making server slightly better environment to handle players with less lag (potentially).
* Note2: I apologize for the commit names, we had forked 2 times Skript-1.8 repo and needed to delete it both time after making a lot of changes inside... so we were tired to even type proper name... apologizes, we'll try to edit if it's possible.

Thank you for reading, hope this PR gets accepted and merged into master branch and continued to be part of Skript-1.8 upcoming updates (2.9.X/2.10.X/2.XX/...) following all changes related to database feature in main Skript repo.

Thank you for making this possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant