upgrade mpmath version#1865
Open
mmatera wants to merge 6 commits into
Open
Conversation
rocky
reviewed
Jul 19, 2026
| dependencies = [ | ||
| "Mathics3_Scanner>=10.0", | ||
| "mpmath>=1.4.0", | ||
| "mpmath>=1.3.0", |
Member
There was a problem hiding this comment.
If 1.4.0 doesn't work, then this should be "mpmath>=1.3.0,<1.4.0", right?
Contributor
Author
There was a problem hiding this comment.
Yep. This is important for the conda-forge package.
mmatera
marked this pull request as ready for review
July 19, 2026 23:06
rocky
reviewed
Jul 20, 2026
| Mathics3 10.0.0 | ||
| Running on linux CPython 3.14.3 (main, Mar 30 2026, 06:42:16) [GCC 13.3.0] | ||
| using SymPy 1.13.3, mpmath 1.3.0, numpy 2.4.4, cython 3.2.4, scipy 1.17.1, skimage 0.26.0 | ||
| using SymPy 1.14.0, mpmath 1.4.0, numpy 2.4.4, cython 3.2.4, scipy 1.17.1, skimage 0.26.0 |
Contributor
Author
There was a problem hiding this comment.
I changed it when I thought 1.4.0 could work here. I just undo the change now.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to check if mpmath 1.3 is still compatible