Skip to content

Fix/heberlr/pr bug neighbors #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincent-noel wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Fix/heberlr/pr bug neighbors #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf73033
Update max cell interactive distance in voxel during position update
heberlr Feb 16, 2026
3b809ae
Refactor max cell interactive distance update to occur after voxel in…
heberlr Feb 16, 2026
7bce940
update max_cell_interactive_distance_in_voxel if cell changed voxel
heberlr Feb 16, 2026
a21f7df
Updated worm and virus-macrophage test results
vincent-noel Sep 15, 2026
0cad4c2
Not checking virus-macrophage tests results anymore
vincent-noel Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
{project: "physimess-sample", name: "PhysiMeSS Sample", binary: "project", config: "config/Fibre_Degradation/mymodel_matrix_degradation.xml", max_time: 120, output_folder: ""},
{project: "physiboss-tutorial", name: "PhysiBoSS Tutorial", binary: "project", config: "config/cell_cycle/PhysiCell_settings.xml", max_time: 300, output_folder: "output"},
{project: "worm-sample", name: "PhysiCell worm", binary: "worm", config: "config/PhysiCell_settings.xml", max_time: 120, output_folder: "output"},
{project: "virus-macrophage-sample", name: "Virus Macrophage", binary: "virus-sample", config: "config/PhysiCell_settings.xml", max_time: 120, output_folder: "output"},
{project: "virus-macrophage-sample", name: "Virus Macrophage", binary: "virus-sample", config: "config/PhysiCell_settings.xml", max_time: 120, output_folder: ""},
{project: "mechano-sample", name: "PhysiCell Mechano", binary: "project", config: "config/PhysiCell_settings.xml", max_time: 120, output_folder: "output"},
{project: "cancer-biorobots-sample", name: "PhysiCell Cancer Biorobots", binary: "cancer_biorobots", config: "config/PhysiCell_settings.xml", max_time: 120, output_folder: ""},
{project: "biorobots-sample", name: "PhysiCell Biorobots", binary: "biorobots", config: "config/PhysiCell_settings.xml", max_time: 120, output_folder: ""},
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests_cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
{"use_physiboss": false, cwd: "build/sample_projects/physimess", name: "PhysiMeSS Sample", binary: "physimess", config: "config/Fibre_Degradation/mymodel_matrix_degradation.xml", max_time: 120, validation_output_folder: ""},
{"use_physiboss": true, cwd: "build/sample_projects_intracellular/boolean/tutorial", name: "PhysiBoSS Tutorial", binary: "tutorial", config: "config/cell_cycle/PhysiCell_settings.xml", max_time: 300, validation_output_folder: "output_physiboss-tutorial"},
{"use_physiboss": false, cwd: "build/sample_projects/worm", name: "PhysiCell worm", binary: "worm", config: "config/PhysiCell_settings.xml", max_time: 120, validation_output_folder: "output_worm-sample"},
{"use_physiboss": false, cwd: "build/sample_projects/virus_macrophage", name: "Virus Macrophage", binary: "virus_macrophage", config: "config/PhysiCell_settings.xml", max_time: 120, validation_output_folder: "output_virus-macrophage-sample"},
{"use_physiboss": false, cwd: "build/sample_projects/virus_macrophage", name: "Virus Macrophage", binary: "virus_macrophage", config: "config/PhysiCell_settings.xml", max_time: 120, validation_output_folder: ""},
{"use_physiboss": false, cwd: "build/sample_projects/mechano", name: "PhysiCell Mechano", binary: "mechano", config: "config/PhysiCell_settings.xml", max_time: 120, validation_output_folder: "output_mechano-sample"},
{"use_physiboss": false, cwd: "build/sample_projects/cancer_biorobots", name: "PhysiCell Cancer Biorobots", binary: "cancer_biorobots", config: "config/PhysiCell_settings.xml", max_time: 120, validation_output_folder: ""},
{"use_physiboss": false, cwd: "build/sample_projects/biorobots", name: "PhysiCell Biorobots", binary: "biorobots", config: "config/PhysiCell_settings.xml", max_time: 120, validation_output_folder: ""},
Expand Down
10 changes: 10 additions & 0 deletions core/PhysiCell_cell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,17 @@ void Cell::update_voxel_in_container()
container->add_agent_to_voxel(this, updated_current_mechanics_voxel_index);
}
current_mechanics_voxel_index=updated_current_mechanics_voxel_index;

// Update max_cell_interactive_distance_in_voxel if needed
if( get_container()->max_cell_interactive_distance_in_voxel[current_mechanics_voxel_index] <
phenotype.geometry.radius * phenotype.mechanics.relative_maximum_adhesion_distance )
{
get_container()->max_cell_interactive_distance_in_voxel[current_mechanics_voxel_index] = phenotype.geometry.radius
* phenotype.mechanics.relative_maximum_adhesion_distance;
}
}



return;
}
Expand Down
370 changes: 370 additions & 0 deletions tests/cases/output_mechano-sample/PhysiCell_settings.xml
View file
Open in desktop

Large diffs are not rendered by default.

Empty file added tests/cases/output_mechano-sample/cell_rules_parsed.csv
View file
Open in desktop
Empty file.
548 changes: 548 additions & 0 deletions tests/cases/output_mechano-sample/cells.csv
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions tests/cases/output_mechano-sample/detailed_rules.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<html>
<body><h1>Cell Hypothesis Rules (detailed)</h1>
<p>In cancer cells:
<ul>
</ul>
</p>
<p>In BM cells:
<ul>
</ul>
</p>
</body>
</html>
6 changes: 6 additions & 0 deletions tests/cases/output_mechano-sample/detailed_rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Cell Hypothesis Rules (detailed)

In cancer cells:

In BM cells:

130 changes: 130 additions & 0 deletions tests/cases/output_mechano-sample/dictionaries.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
Signals (with synonyms):
=======================
20 : apoptotic
15 : attacking
12 : contact with BM
9 : contact with apoptotic cell
9 : contact with apoptotic cells
12 : contact with basement membrane
5 : contact with cancer
5 : contact with cell type 0
6 : contact with cell type 1
8 : contact with dead cell
8 : contact with dead cells
7 : contact with live cell
7 : contact with live cells
10 : contact with necrotic cell
10 : contact with necrotic cells
11 : contact with other dead cell
11 : contact with other dead cells
18 : current time
19 : custom 0
19 : custom: sample
19 : custom:sample
13 : damage
14 : damage delivered
16 : dead
18 : global time
2 : grad(substrate)
2 : gradient of substrate
1 : internalized substrate
1 : intracellular substrate
15 : is attacking
16 : is dead
20 : is_apoptotic
21 : is_necrotic
21 : necrotic
3 : pressure
0 : substrate
2 : substrate gradient
18 : time
17 : total attack time
14 : total damage delivered
4 : volume


Behaviors (with synonyms):
=========================
19 : adhesive affinity to BM
18 : adhesive affinity to cancer
18 : adhesive affinity to cell type 0
19 : adhesive affinity to cell type 1
10 : apoptosis
36 : asymmetric division to BM
35 : asymmetric division to cancer
30 : attack BM
29 : attack cancer
29 : attack cell type 0
30 : attack cell type 1
44 : attack damage rate
45 : attack duration
41 : cell attachment rate
42 : cell detachment rate
22 : cell-BM adhesion
23 : cell-BM repulsion
16 : cell-cell adhesion
17 : cell-cell adhesion elastic constant
21 : cell-cell repulsion
22 : cell-membrane adhesion
23 : cell-membrane repulsion
15 : chemotactic response to substrate
15 : chemotactic sensitivity to substrate
37 : custom 0
37 : custom: sample
37 : custom:sample
4 : cycle entry
46 : damage rate
47 : damage repair rate
4 : exit from cycle phase 0
5 : exit from cycle phase 1
6 : exit from cycle phase 2
7 : exit from cycle phase 3
8 : exit from cycle phase 4
9 : exit from cycle phase 5
32 : fuse to BM
31 : fuse to cancer
31 : fuse to cell type 0
32 : fuse to cell type 1
40 : immunogenicity to BM
39 : immunogenicity to cancer
39 : immunogenicity to cell type 0
40 : immunogenicity to cell type 1
38 : is movable
38 : is_movable
43 : maximum number of cell attachments
13 : migration bias
14 : migration persistence time
12 : migration speed
38 : movable
11 : necrosis
28 : phagocytose BM
24 : phagocytose apoptotic cell
27 : phagocytose cancer
27 : phagocytose cell type 0
28 : phagocytose cell type 1
25 : phagocytose necrotic cell
26 : phagocytose other dead cell
28 : phagocytosis of BM
24 : phagocytosis of apoptotic cell
24 : phagocytosis of apoptotic cells
27 : phagocytosis of cancer
25 : phagocytosis of necrotic cell
25 : phagocytosis of necrotic cells
26 : phagocytosis of other dead cell
26 : phagocytosis of other dead cells
20 : relative maximum adhesion distance
3 : substrate export
0 : substrate secretion
1 : substrate secretion saturation density
1 : substrate secretion target
2 : substrate uptake
34 : transform to BM
33 : transform to cancer
33 : transform to cell type 0
34 : transform to cell type 1
34 : transition to BM
33 : transition to cancer
33 : transition to cell type 0
34 : transition to cell type 1


Empty file added tests/cases/output_mechano-sample/empty.txt
View file
Open in desktop
Empty file.
Loading
Loading