feat(viewer): give the menu bar the shape of the simulator it replaces - #53
Merged
Merged
Conversation
Nine menus, no View. I/O and Features are new, and the orientation, Siri, Action Button and app switcher actions existed in the engine without a way to reach them.
The dot was a titlebar accessory from before the floating toolbar existed, so it landed on top of the runtime the toolbar now draws there.
An availability check gates the call at runtime, not the symbol at compile time, so the property is set through the runtime instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Nine menus, matching the simulator this replaces: application, File, Edit, Device, I/O, Features, Debug, Window, Help. View is gone and nothing was left stranded in it. I/O and Features are new.
File gains Save Screen ⌘S and Record Screen ⌘R from Device, plus Stop Recording as its own item rather than a second meaning for Record Screen. Device is rebuilt in Simulator.app's order and gains Orientation, Action Button, Siri ⌥⇧⌘H and App Switcher ⌃⇧⌘H, with Shake moving in from Debug. I/O holds the volume keys and Features holds Toggle Appearance, both moved out of Device. Window gains Show Device Bezels, Stay On Top and Enter Full Screen.