feat(viewer): add the standard macOS menus, Apple's shortcuts and menu icons - #52
Merged
Merged
Conversation
The menu bar was built item by item as features landed, so the conventions every Mac app has were missing. The zoom shortcuts change to match the simulator this replaces.
AppKit decorates the rows it inserts itself, not the ones a menu built in code hands it, so the symbols are named from the inventory.
preferredImageVisibility is new there and defaults to automatic, which hides the image for a menu built in code.
Mastersam07
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: The menu bar was built item by item as features landed, so the conventions every Mac app has were missing. Added: About, Services, Hide, Hide Others and Show All in the application menu; Undo, Redo, Cut, Copy and Select All as standard responder actions in Edit; a Window menu with Minimize, Zoom, Bring All to Front and
NSApp.windowsMenuset so the open device windows are listed; and a Help menu, empty on purpose, because settingNSApp.helpMenuis what puts the macOS search field there. No Settings item: there is nothing to put in it yet.AppKit also fills in more than expected once
windowsMenuis set: Fill, Center, Move & Resize, Full Screen Tile and Remove Window from Set appear on their own, as do Writing Tools, AutoFill, Start Dictation and Emoji & Symbols in Edit.