Conversation
added 4 commits
August 24, 2026 03:32
Night vision is all-or-nothing today: the toggle drops you straight into the full potion effect. This makes it a curve instead - a lit strength, a dark strength, the light level counted as lit, an exponent for the shape, and a fade speed. VisionHandler recomputes the target every client tick and eases towards it; a GameRenderer mixin returns that value from the night vision scale so the vignette follows it. Off by default (nv_curve = false), so nothing changes unless you turn it on. The Forge mixin block in build.forge.gradle.kts was commented out because there were no mixins to build a refmap from - there is one now, so it goes back in. scripts/NightVisionCurveCheck.java is a plain javac/java -ea check for the curve maths, including the hand-edited-config values the sliders cannot reach.
Sliders for the five curve values plus the toggle, with English, German and Austrian strings.
Five curve values is a lot to ask of someone who just wants the mod to work. The preset dropdown covers the useful combinations and moves the sliders into an Advanced subcategory underneath; touching a slider reads back as Custom. Always is the mod's current behaviour, so the default preset is what everyone already has. The preset applies in the saving runnable rather than in its own save consumer: Cloth saves entries in order and cascades into subcategories, so the Advanced sliders would otherwise write their unchanged values back over it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds five presets: Slow adaptation, Adaptive, Always, Never, and Custom.
Moving the sliders switches to Custom. Default is Always, so current behaviour stays the same.
Based on the curve PR.
AI helped fix a small bug where preset selection was resetting auto_nv.