Add tlr legality to fix issues with decklist retrieval#84
Open
Matteas-Eden wants to merge 2 commits into
Open
Conversation
Author
|
Let me know if I've missed anything else important, as it's my first time contributing to this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recently, I noticed that an app I made which uses
moxfield-apistarted failing. After looking into it, and pasting the error into my nearest LLM to decipher, it turns out that Moxfield has updated the legalities in their list to include "TLR". That stands for Tiny Leaders Reborn, and it is a competitive-focused commander-alike format.So to fix this library, I've updated the Zod schema to support "tlr".
Validation
I built the package with my changes, copied over the artifacts into my app's
node_modules, and confirmed that the deck retrieval worked.I did also run the unit tests, but almost all of them failed. However, they also fail on
main, and some of the Moxfield URLs it tests against don't seem to exist anymore (404 pages). I'm going to suggest that it's not important those tests pass for this PR to merge.