Skip to content

feat(gui): apply windows 10/11 style via qss and modernize pyside6 exec methods - #93

Open
MarcusStill wants to merge 1 commit into
masterfrom
feature/pyside6-win11-style-1336875947648895051
Open

MarcusStill wants to merge 1 commit into
masterfrom
feature/pyside6-win11-style-1336875947648895051

Conversation

@MarcusStill

Copy link
Copy Markdown
Owner

This PR addresses the request to modernize the PySide6 UI by creating a Windows 10/11 aesthetic via a QSS style sheet. It loads the style securely using pathlib at startup.

Furthermore, several PySide6 modernization best practices have been applied, such as upgrading .exec_() to .exec(), ensuring the global MainWindow doesn't get garbage-collected prematurely, and verifying that the loguru event loop properly finalizes logging strings with .complete() before closing.


PR created automatically by Jules for task 1336875947648895051 started by @MarcusStill

…ec methods

- Created `files/style.qss` defining a flat, lightweight Windows 10/11 aesthetic (Segoe UI, #0078D4 accent).
- Modified `main.py` to dynamically load `style.qss` at app startup, retaining the 'Fusion' style as a base.
- Changed deprecated `exec_()` calls on QDialog subclasses to the modern `exec()`.
- Addressed garbage collection issue with main window instantiation by binding it to `QtWidgets.QApplication.instance().main_window`.
- Added `logger.complete()` before application exit to ensure thread-safe log flushing.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant