Skip to content

Fix delayed and missing log file entries - #89

Open
MarcusStill wants to merge 1 commit into
devfrom
fix-log-buffering-5607380065798579115
Open

MarcusStill wants to merge 1 commit into
devfrom
fix-log-buffering-5607380065798579115

Conversation

@MarcusStill

Copy link
Copy Markdown
Owner

Fixes an issue where application logs were not written to disk immediately and could be completely lost if the application crashed or was forcibly closed before the log buffer filled up.


PR created automatically by Jules for task 5607380065798579115 started by @MarcusStill

- Enforce line-buffering on loguru file output by adding `buffering=1` to ensure logs are written to disk immediately rather than waiting for the buffer to fill.
- Add an optional `log_level` setting in the `[OTHER]` section of `config.ini` to dynamically control verbosity in production without modifying source code (defaults to `DEBUG`).
- Change PySide6 exit sequence from `sys.exit(app.exec())` to store exit code and explicitly quit, preventing issues with finalization hooks and log flushes not running correctly.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant