Skip to content

Fix delayed logging and lost error logs - #84

Open
MarcusStill wants to merge 1 commit into
devfrom
fix-loguru-buffering-7553659740736156002
Open

MarcusStill wants to merge 1 commit into
devfrom
fix-loguru-buffering-7553659740736156002

Conversation

@MarcusStill

Copy link
Copy Markdown
Owner

Фикс бага с кэшированием записи логов в файл и потерей логов об ошибках в процессе асинхронной работы loguru.

  • В logger.add() в main.py добавлен параметр buffering=1, чтобы заставить python использовать line-buffering и сразу писать каждую строчку на диск.
  • Добавлена выгрузка параметра log_level из конфигурации для логгера.
  • Добавлены вызовы logger.complete() перед нештатными падениями и перед завершением приложения для того, чтобы фоновые потоки loguru могли слить логи на диск.

PR created automatically by Jules for task 7553659740736156002 started by @MarcusStill

    - Implemented `buffering=1` for line-buffering in logger.add() so logs immediately flush to disk instead of being cached in memory until closure.
    - Updated `logger.add()` to accept a fallback configurable uppercase log level dynamically fetched from the [OTHER] section of `config.ini` avoiding breaking crashes for lacking configurations.
    - Added explicit `logger.complete()` before system exits (in exceptions hook, missing database startup, and standard GUI main exit) to ensure queued log processes safely conclude before shutting down the main app avoiding lost error messages.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant