Fix log file buffering delays and enqueue data loss - #78
MarcusStill wants to merge 1 commit into
Conversation
- Add buffering=1 to logger.add to ensure immediate line buffering - Introduce optional log_level reading from config.ini - Add logger.complete() before app exit and unhandled exceptions to guarantee flush of asynchronous enqueue queues
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This patch resolves an issue where logs in PyMASL were not written immediately to the output file (requiring an application restart to flush), and where critical error logs were occasionally lost upon unexpected termination. The
logurusetup has been updated to enforce line-buffering and graceful shutdown by callinglogger.complete(). Also handles reading optional log levels from configuration.PR created automatically by Jules for task 16044627121179896690 started by @MarcusStill