Skip to content

Marcosdy/refactor vault client#576

Open
MarcosDY wants to merge 50 commits into
mainfrom
marcosdy/refactor-vault-client
Open

Marcosdy/refactor vault client#576
MarcosDY wants to merge 50 commits into
mainfrom
marcosdy/refactor-vault-client

Conversation

@MarcosDY
Copy link
Copy Markdown
Owner

@MarcosDY MarcosDY commented Apr 18, 2026

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Description of change

Which issue this PR fixes

@InverseIntegral @MarcosDY
Create skeleton of HC Vault based server keymanager plugin (spiffe#5058)
59c1e01 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Start implementing signing function for HC vault (spiffe#5058)
9ab7168 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make SignData work with HC Vault keymanager plugin (spiffe#5058)
22c5e4c 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Rename transit key type constants (spiffe#5058)
07d1d4f 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make vault client more robust by handling invariant violations (spiff…
2ac088f 
…e#5058)

Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Move logic from plugin to vault client (spiffe#5058)
40fcff7 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Refactor logic to generate vault client (spiffe#5058)
f00b2b0 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Use latest key version to sign data (spiffe#5058)
ce9d025 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Move data encoding to vault client (spiffe#5058)
8a19081 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add simple vault client auth test (spiffe#5058)
dd5a1e5 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove unused test code (spiffe#5058)
36a8c16 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support configuring vault namespace (spiffe#5058)
4d77868 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support AppRole authentication (spiffe#5058)
03684ad 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make transit engine path configurable (spiffe#5058)
e30f820 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add comments to exported functions (spiffe#5058)
6f38a50 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support certificate authentication (spiffe#5058)
0997f61 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add missing app role auth test case (spiffe#5058)
81400cc 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support K8s auth (spiffe#5058)
30032f0 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support verifying server certificate via CA (spiffe#5058)
73440aa 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault client create key function (spiffe#5058)
62e3059 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault client get key function (spiffe#5058)
8f4e8d1 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault client sign data function (spiffe#5058)
44ae6a6 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault key manager configure function (spiffe#5058)
19fb1bf 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault key manager generate key function (spiffe#5058)
dcd1c40 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Load keys from Vault on configure (spiffe#5058)
65d9c9a 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test get key entry function (spiffe#5058)
37a3335 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test get keys function (spiffe#5058)
0bf84de 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add simple plugin documentation (spiffe#5058)
a2aada4 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove unused hooks (spiffe#5058)
5ccd0f2 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Fix hcl examples in documentation (spiffe#5058)
ac1a259 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
InverseIntegral and others added 15 commits April 18, 2026 11:41
@InverseIntegral @MarcosDY
Add KeyManager vault integration test (spiffe#5058)
3fe431e 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add warning when skipping TLS verification (spiffe#5058)
0b4d56c 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Prevent shadowing of variable (spiffe#5058)
9307469 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Improve comment (spiffe#5058)
dffcf54 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add type assertion check (spiffe#5058)
0fd13b0 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove TODO (spiffe#5058)
37f1011 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove TODO (spiffe#5058)
5764630 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Introduce unique server id for HA setup (spiffe#5058)
2d44f58 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make key names unique by adding a UUID (spiffe#5058)
500c5ae 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Cleanup keys with same SPIRE key id (spiffe#5058)
1727d44 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@MarcosDY
resolve lint issues and implement Validate in plugin
81ed276 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
Resolve file issue
52480a3 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
Require validate provided key identifier
125888d 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
refactor
bd29ac0 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
try to resovle flaky tests
f2cdce6 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY MarcosDY force-pushed the marcosdy/refactor-vault-client branch from e523634 to f2cdce6 Compare April 18, 2026 16:58
@MarcosDY
more tests...
eb18772 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY MarcosDY force-pushed the marcosdy/refactor-vault-client branch from 5284516 to eb18772 Compare April 18, 2026 17:27
MarcosDY added 4 commits April 18, 2026 15:00
@MarcosDY
More updates
f4ef5f1 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
resovle issues on integration tests
9b49717 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
pr changes
349d1a6 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
resolve some of the comments
6353d97 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcosDY @InverseIntegral