Repository navigation
Conversation
Connect pages, setup dialogs and onboarding each drew their own progress line: mono with underline, sans with underline, slash crumbs, numbered uppercase, or none. answerTrail in the kit replaces all of them: done steps as answer chips, the current step underlined in primary. The Cost add-source dialogs gain a Provider -> Connect trail. maple/one-step-trail flags aria-current="step" outside the kit, so a new flow cannot grow a second trail.
This comment has been minimized.
This comment has been minimized.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The check is decorative, so a static chip now carries a hidden "(done)"; a reopenable chip already says it in its button name.
This comment has been minimized.
This comment has been minimized.
At phone width a nowrap chip with a long answer pushed the trail past the viewport; the answer now ellipsizes inside the chip.
Maple review🟢 Confidence 9/10 · safe to merge. Contained CSS fix in one kit view; the shrink chain that makes the ellipsis appear is verified by reading the classes, and the truncation itself has no test. Replaces five hand-rolled step trails with one kit
|

Every step flow drew its own progress line: a mono trail on connect pages, a sans one in the Google Cloud dialog, slash crumbs in onboarding, a numbered uppercase
1 WRITE / 2 REVIEWin the status page dialogs, and nothing in the Cost add-source dialogs. They now share one kit component.What changed
answerTrail(packages/views/src/ui/answer-trail.ts) replacesstepTrailand the three hand-rolled trails. Done steps are receipt chips with the answer they were given ("Acme", "Cloudflare"), the current step is underlined in primary, later steps are muted. Sans, no numbers. A done step that can be reopened (onboarding) is a button named "Acme, go to Name"./sources/newand every connect flow it frames (AWS, Google Cloud, Cloudflare, Railway, PlanetScale, Supabase, GitHub, Prometheus), the Google Cloud configure dialog, onboarding, and the status page incident dialogs.maple/one-step-trailflagsaria-current="step"anywhere but the kit component, so a new flow can't grow a second trail. Documented indocs/design-rules.md.Before / after
After, more states: onboarding with a done answer chip, the Cost picker, and the connect page in light mode.
Verification
apps/webandpackages/viewstypecheck;bun run lint:foldkitclean.aria-current="step"on Write instead of pinning the old numbered text.h.AriaCurrent("step")and{ "aria-current": "step" }in a probe file, and is quiet on the kit file./lab/*(aws-connection, sources, gcp-connect, onboarding, cost).The status page incident dialog does not open from the lab's editor page in headless Chrome, so it has no screenshot; the scene test covers it.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit