Repository navigation
fix(ui): selection is an opaque pair, primary-foreground on primary - #2573
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 13, 2026 in 1m 51s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Opaque pair computes to 6.5:1 (light) and 7.9:1 (dark), and the chip rule reaches the kit path that renders every badge.
no findings · tests not needed · risk medium
Makes ::selection an opaque primary-foreground on primary pair and exempts chips (badges, text-on-fill, text-primary-foreground) from the band, plus matching design-rules text. Contained CSS change, safe to merge.
::selectionpairsprimary-foregroundonprimaryinstead of a 40% wash- Chips drop the band for a 1px
currentColorunderline native-select.styles.tsloses its own redundantselection:pair
What was checked
- Contrast of the new pair computed from tokens.css:22/23 and 265/266 — 6.51:1 light, 7.87:1 dark
data-slot="badge"is emitted by thebadge/badgeClasskit helpers andhero-chip, so tinted chips are covered- Grep for
selection:bg-/selection:text-finds no call site left, matching the doc rule
9d51585 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading