Skip to content

feat(charts): quieter chart chrome: solid grid, short time ticks, lighter stacked areas - #2569

Merged
Makisuo merged 3 commits into
mainfrom
feat/chart-chrome-refine
Nov 13, 2026
Merged

Makisuo merged 3 commits into
mainfrom
feat/chart-chrome-refine

test(ui): match a tick's space by class, not by the literal the runti…

b7671cb
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 13, 2026 in 45s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. Only the tick-rule test file changed since the last pass, and I reproduced every new assertion exactly under Node 24 / ICU 78.3.
no findings · tests covered · risk medium

Quieter shared chart chrome: solid hairline grid, shorter 12-hour time ticks, light-edged stacked areas, display-face tooltip values and muted legends. The test file added since the last pass pins the tick rules and holds on the head commit.

  • formatTickClock drops a 12-hour tick's minutes on the hour and reads them off an en-US formatter
  • Grid renamed DASHED_Y_GRID → Y_GRID and drawn solid across 13 definitions
  • Stacked areas fill at 30% under a top edge; bars round only their top
What was checked
  • Reproduced all eight new tick assertions on the head with node -e, ICU 78.3: all pass
  • The Arabic-digit case fails under the old formatToParts(...) === "00" check (git show 8ac9faf), so it pins the fix
  • \s in the new regexes matches both the ASCII and narrow no-break space ICU prints

b7671cb · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.