Skip to content

feat(views): find in page reaches every row of the logs stream - #2568

Merged
Makisuo merged 3 commits into
mainfrom
t3/adopt-isdk-list-behaviors
Nov 13, 2026
Merged

Makisuo merged 3 commits into
mainfrom
t3/adopt-isdk-list-behaviors

test(views): fire beforematch through bindFindable against a real vir…

bca8825
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 13, 2026 in 1m 29s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The change since the last review adds a happy-dom test of the beforematch handler plus its devDependency; the assertions track bindFindable and TanStack's start - scrollMargin offset exactly.
no findings · tests covered · risk low

The delta since the last review is packages/views/src/lib/findable.test.ts, happy-dom in that package's devDependencies, and the lockfile. The test drives bindFindable over a real @tanstack/virtual-core virtualizer and covers the handler the earlier review flagged as untested; nothing needs changing.

  • findable.test.ts fires bubbling beforematch on a stand-in and its group through bindFindable
  • happy-dom added as a @maple/views devDependency, same ^21.0.4 as apps/landing
  • Docblock @vitest-environment happy-dom overrides the package's node default for this file
What was checked
  • match(40) asserts both top and height from measurementsCache and one report per match, since the group has no findable-index (findable.ts:184)
  • The group dispatch reaches bindFindable only through bubbling, so the one-report assertion is a real check, not a tautology
  • happy-dom version matches the existing apps/landing devDependency, and src/**/*.test.ts picks the file up

bca8825 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.