Repository navigation
feat(views): find in page reaches every row of the logs stream - #2568
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 13, 2026 in 1m 29s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. The change since the last review adds a happy-dom test of the beforematch handler plus its devDependency; the assertions track bindFindable and TanStack's start - scrollMargin offset exactly.
no findings · tests covered · risk low
The delta since the last review is packages/views/src/lib/findable.test.ts, happy-dom in that package's devDependencies, and the lockfile. The test drives bindFindable over a real @tanstack/virtual-core virtualizer and covers the handler the earlier review flagged as untested; nothing needs changing.
findable.test.tsfires bubblingbeforematchon a stand-in and its group throughbindFindablehappy-domadded as a@maple/viewsdevDependency, same^21.0.4asapps/landing- Docblock
@vitest-environment happy-domoverrides the package'snodedefault for this file
What was checked
match(40)asserts bothtopandheightfrommeasurementsCacheand one report per match, since the group has nofindable-index(findable.ts:184)- The group dispatch reaches
bindFindableonly through bubbling, so the one-report assertion is a real check, not a tautology happy-domversion matches the existingapps/landingdevDependency, andsrc/**/*.test.tspicks the file up
bca8825 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading