Repository navigation
fix(db): join the two migration branches left on main - #2567
Conversation
cost_connections and alert_rules_audit_detection were both generated from the same snapshot, so the folder had two heads and the parity test failed on main. This adds the merge migration the next generate would have written. It runs no SQL.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Maple review🟢 Confidence 10/10 · safe to merge. Empty-body merge migration whose snapshot I diffed as the exact union of both parents, restoring the existing parity test. Adds a custom merge migration (
Before merge
|
|
Merged with 1 step from "Before merge" still open. If it is done, tick it on the review comment; if not, now is the time.
|
What
mainis red at b4fd88f:packages/db/src/tables/parity.test.tsfails "leave the migrations folder consistent" (two heads, one expected), and with it theCI passedgate on every open PR.20261112221939_cost_connections(#2541) and20261113122938_alert_rules_audit_detection(#2532) were both generated from the same parent snapshot.db:checkreports them as independent branches that the next generate merges. This is that merge, written withdb:generate --custom: a migration with both as parents, the current schema as its snapshot, and no SQL.Verification
bun run --cwd packages/db db:check: 187 migrations, ok, no independent branches reported.bunx vitest run src/tables/parity.test.ts: 5 passed (1 failed before).db:generatewith no flags reports no schema changes, so the tables and the new head agree.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.